Int wrapping multiplication improvements #998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
- Coverage 79.87% 79.84% -0.03%
==========================================
Files 163 163
Lines 17593 17696 +103
==========================================
+ Hits 14052 14129 +77
- Misses 3541 3567 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simplify Int::wrapping_mul and add test Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
commented
Nov 12, 2025
| pub const SIGN_MASK: Self = Self::MIN; // Bit sequence (be): 1000....0000 | ||
|
|
||
| /// All-one bit mask. | ||
| pub const FULL_MASK: Self = Self(Uint::MAX); // Bit sequence (be): 1111...1111 |
Contributor
Author
There was a problem hiding this comment.
This constant was public, but I can't imagine what it would be needed for, besides the internal usage in calculating MINUS_ONE which has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes
Int::wrapping_mulandUint::checked_mul_intto make use ofUint::wrapping_mul, and addsInt::saturating_mul.